Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust lrna for fees #139

Closed
wants to merge 20 commits into from
Closed

Adjust lrna for fees #139

wants to merge 20 commits into from

Conversation

poliwop
Copy link
Collaborator

@poliwop poliwop commented Jun 16, 2023

No description provided.

@poliwop poliwop marked this pull request as ready for review June 19, 2023 17:14
@poliwop poliwop requested a review from jepidoptera June 19, 2023 17:14
Copy link
Contributor

@jepidoptera jepidoptera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks great. The only things I could comment on feel so nitpicky that I'm not even going to.

jepidoptera and others added 4 commits June 27, 2023 11:56
* changed withdrawal fee for stableswap to match our runtime implementation
# Conflicts:
#	hydradx/model/amm/omnipool_amm.py
#	hydradx/notebooks/Omnipool/LP_fees_analysis.ipynb
#	hydradx/tests/test_omnipool_amm.py
@poliwop
Copy link
Collaborator Author

poliwop commented Sep 19, 2023

The code changes have been previously merged. The spec changes are not in the correct place (they are in spec of current Omnipool) to be merged unless we implement the change in PROD.

@poliwop poliwop closed this Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants