Model lp fees #140
Merged
Model lp fees #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specced LRNA mint in Spec.ipynb
… decorator. Loosening acceptable error in hope this resolves issue.
…or LPs is approximately double
* changed withdrawal fee for stableswap to match our runtime implementation
poliwop
requested changes
Jul 3, 2023
There was a problem hiding this comment.
The results in this notebook can be confirmed in this spreadsheet:
https://docs.google.com/spreadsheets/d/1Fh0StOPIDhazhQgwsXHVVvubJCqJpgfJTA8ZdN53bV0/edit?usp=sharing
This does validate the notebook. I think though that if we are going to share these results, it makes sense to do it with a simple spreadsheet. Can we think of extensions to this notebook to make it more realistic? Having non-zero LRNA fees is a simple one, it's not immediately obvious how to incorporate that into the spreadsheet.
… graph at the bottom which separately extrapolates to one year
# Conflicts: # hydradx/notebooks/Omnipool/LP_fees_analysis.ipynb
poliwop
requested changes
Jul 18, 2023
poliwop
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modeling for LP fees without the latest LRNA spec update