Fixed bug in Omnipool arbitrager #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jepidoptera
approved these changes
Jul 12, 2023
There was a problem hiding this comment.
I see what you did there, and that looks right. Do you think there should be a test for this? (Basically verifying that the arbitrageur doesn't take unprofitable trades.)
I see that one of the checks is failing. After looking into it, it's an edge case in test_add_liquidity where the liquidity goes over the 10^12 limit. Given that we've heard from Martin that that isn't actually part of the production implementation, should we just remove that limit?
|
There is a test for unprofitable arb trades, that's how we caught this issue. We didn't catch it until now because the fuzzer didn't hit the right case. |
jepidoptera
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.