Model stableswap il #147
Closed
Model stableswap il #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ppropriate arb trade. It now fails.
…turning a mutated copy
# Conflicts: # hydradx/model/amm/stableswap_amm.py # hydradx/model/amm/trade_strategies.py
# Conflicts: # hydradx/model/amm/trade_strategies.py
…stableswap-IL # Conflicts: # hydradx/model/amm/stableswap_amm.py # hydradx/model/amm/trade_strategies.py
…turning a mutated copy
…creates a new object
…eck in trade_strategy.execute fails)
…g tests to fail and is out of scope
# Conflicts: # hydradx/model/amm/global_state.py # hydradx/model/amm/stableswap_amm.py
poliwop
requested changes
Sep 13, 2023
| " for trade_size in trade_sizes:\n", | ||
| " lp_state, lp_agent = initial_state.copy(), initial_agent.copy()\n", | ||
| " for tkn in initial_agent.asset_list:\n", | ||
| " StableSwapPoolState.execute_add_liquidity(\n", |
There was a problem hiding this comment.
This notebook doesn't work with the refactor.
| "\n", | ||
| " for event in events:\n", | ||
| " # agent withdraws assets in equal proportion\n", | ||
| " StableSwapPoolState.execute_remove_uniform(\n", |
There was a problem hiding this comment.
This function doesn't appear to exist in this branch?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.