Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staking docs #168

Merged
merged 6 commits into from
Sep 13, 2023
Merged

Staking docs #168

merged 6 commits into from
Sep 13, 2023

Conversation

vgantchev
Copy link
Collaborator

No description provided.

docs/staking.md Outdated Show resolved Hide resolved
Copy link
Contributor

@martinfridrich martinfridrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also explain stake increase.
It changes points amount to offset additional stake and it also pays rewards which are locked with staking lock. Portion of these "locked rewards" is unlocked when user claims and everything is unlocked when unstake.
Maybe we can also mention unstake automatically claim rewards.

We should probably mention that users can't stake orml-vested tokens and tokens which are already staked, other locks should work.

Maybe we should explain how votes are recorded in the staking. They are recorded up to skated amount with used conviction e.g.
for position with 1M staked
vote: 2M + 3x conviction is not the same as vote: 1M + 6x conviction
For staking it's vote: 1M + 3x conviction

@vgantchev
Copy link
Collaborator Author

@martinfridrich thanks for the comments, changes will be added later in a separate PR

docs/staking.md Outdated Show resolved Hide resolved
docs/staking.md Outdated Show resolved Hide resolved
docs/staking.md Outdated Show resolved Hide resolved
Copy link
Contributor

@lolmcshizz lolmcshizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a few comments on top of Martin's but in general looks gooooood!

@vgantchev vgantchev merged commit 742e879 into main Sep 13, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants