Separate call to mark prompts as processed #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KasparPeterson
commented
Mar 27, 2024
| IChatGpt(callbackAddresses[promptId]).onOracleLlmResponse( | ||
| promptCallBackId, | ||
| response, | ||
| errorMessage | ||
| ); | ||
| } | ||
|
|
||
| function markPromptAsProcessed(uint promptId) public onlyWhitelisted { | ||
| isPromptProcessed[promptId] = true; |
There was a problem hiding this comment.
In the previous function addResponse the IChatGpt(callbackAddresses[promptId]).onOracleLlmResponse() can fail and the oracle retries this on restart. This is a suggestion from @kgrofelnik to have a separate tx to mark it as done
KasparPeterson
force-pushed
the
handling-failed-txs
branch
from
98dfe77
to
d6878e7
Compare
kristjanpeterson1
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.