Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iss1479 and 1685 - Reset and Cancel an active test run. #213

Merged
merged 22 commits into from
Feb 20, 2024
Merged

Iss1479 and 1685 - Reset and Cancel an active test run. #213

merged 22 commits into from
Feb 20, 2024

Conversation

jadecarino
Copy link
Contributor

@jadecarino jadecarino commented Feb 19, 2024 •
edited
Loading

  • Reset and Cancel commands implemented
  • Unit tests for the command parsing
  • Unit tests for the command responses
  • Bash script to test both commands with a real ecosystem test
  • Docs for the repository's README
  • Generated docs

jadecarino and others added 20 commits January 18, 2024 16:09
@jadecarino
Started to add CLI commands for reset and delete
67cae35 
Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
@jadecarino
Continuing with runs reset command
244f0cc 
Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
@jadecarino
Merge branch 'main' of github.com:galasa-dev/cli into iss1479
5631054
@jadecarino
Runs reset unit tests and functional
0484ccd 
Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
@jadecarino
Resolved merge conflicts
c289c52 
Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
@eamansour
Compare test images pixel-by-pixel and ignore colours
5719484 
Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com>
@jadecarino
Runs cancel and some unit tests
86c8329 
Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
@eamansour
Update comment and black RGBA value
9a3a520 
Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com>
@jadecarino
Merge branch 'em-image-comparison-fix' of github.com:galasa-dev/cli i…
b263c92 
…nto iss1479
@jadecarino
Some more changes
9ad9417 
Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
@jadecarino
Merge
183182b 
Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
@jadecarino
Updated unit tests for new 202 response
d4f5e84 
Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
@jadecarino
Updated status code the CLI expects back from the API
8e5fcee 
Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
@jadecarino
Unit test updates for new logic
c203e5d 
Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
@jadecarino
Extracted common functions into new file
10cf1b9 
Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
@jadecarino
Removed unneeeded error message
ab479a5 
Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
@jadecarino
Extracted constants for unit tests into common file
12cb87d 
Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
@jadecarino
Final commit for this issue - bash script for testing the commands
49ba412 
Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
@jadecarino
Clarify README
75f2f11 
Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
@jadecarino
Fix script
c151d08 
Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
This was referenced Feb 19, 2024
Closed
Closed
@galasa-team
Copy link

Build successful

techcobweb
techcobweb reviewed Feb 19, 2024
View reviewed changes
README.md Show resolved Hide resolved
@jadecarino
Added clarification to the README as per Mike's comment
cf763c6 
Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
@galasa-team
Copy link

Build successful

techcobweb
techcobweb reviewed Feb 20, 2024
View reviewed changes
pkg/runs/runsCancel.go Outdated Show resolved Hide resolved
techcobweb
techcobweb reviewed Feb 20, 2024
View reviewed changes
pkg/runs/runsReset.go Outdated Show resolved Hide resolved
techcobweb
techcobweb approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@techcobweb techcobweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments, but it looks good to me.

@jadecarino
Ensure logging has new line
ec3742e 
Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
@galasa-team
Copy link

Build successful

@jadecarino jadecarino merged commit 053903f into main Feb 20, 2024
4 checks passed
@jadecarino jadecarino deleted the iss1479 branch February 20, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@techcobweb techcobweb techcobweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jadecarino @galasa-team @techcobweb @eamansour