Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation of property string patterns prior to trying to construct a URL #216

Merged
merged 6 commits into from
Mar 1, 2024

Conversation

Akyiaa
Copy link
Contributor

@Akyiaa Akyiaa commented Feb 27, 2024

Signed-off-by: Fiona Ampofo <64271621+Akyiaa@users.noreply.github.com>
@galasa-team
Copy link

Build successful

Signed-off-by: Fiona Ampofo <64271621+Akyiaa@users.noreply.github.com>
@galasa-team
Copy link

Build successful

Signed-off-by: Fiona Ampofo <64271621+Akyiaa@users.noreply.github.com>
@galasa-team
Copy link

Build successful

Signed-off-by: Fiona Ampofo <64271621+Akyiaa@users.noreply.github.com>
Signed-off-by: Fiona Ampofo <64271621+Akyiaa@users.noreply.github.com>
@Akyiaa Akyiaa requested review from KirbyKatcher and Wyvinar and removed request for Wyvinar March 1, 2024 10:58
@galasa-team
Copy link

Build successful

@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-216-l28nc for details. If you are unable to do so, please contact a member of the Galasa team.

docs/generated/errors-list.md Outdated Show resolved Hide resolved
pkg/properties/propertiesSet_test.go Outdated Show resolved Hide resolved
pkg/properties/propertiesSet_test.go Show resolved Hide resolved
Signed-off-by: Fiona Ampofo <64271621+Akyiaa@users.noreply.github.com>
@galasa-team
Copy link

Build successful

@Akyiaa Akyiaa merged commit 46a0520 into main Mar 1, 2024
4 checks passed
@Akyiaa Akyiaa deleted the fiona-1607-validatePropertyValues branch March 1, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants