remove the need for the framework test.streams cps property #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mike Cobbett <77053+techcobweb@users.noreply.github.com>
|
Build successful |
techcobweb
commented
Apr 3, 2024
eamansour
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mike Cobbett 77053+techcobweb@users.noreply.github.com
Instead of using the framework.test.streams property, use a wider query to find all the test.stream.xxx.repo properties in the CPS... that gives the same list (one would hope)
Doing this means we shouldn't need to manually maintain the test.streams CPS property, which is a pain.
This is really a sticking plaster where what we should have is a REST service which delivers the streams as structures.
But if we can avoid people needing to maintain the test.streams value that would be a help.