Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove temporary code and return an error instead of trying to send unauthenticated requests #230

Merged
merged 9 commits into from
Apr 10, 2024

Conversation

eamansour
Copy link
Member

@eamansour eamansour commented Apr 9, 2024

For galasa-dev/projectmanagement#1473 and galasa-dev/projectmanagement#1820

Changes:

  • Now that authentication is mandatory, this PR removes the temporary code that was previously used to fall back to sending unauthenticated requests to the API server if a user could not authenticate with the ecosystem.
    • Instead, an error will be returned informing the user that they will need to authenticate with the ecosystem.
  • Changed the requestor value used in the ecosystem tests to use my ID temporarily to get the main builds passing again
  • Fixed an issue where the "Authorization" header was not being set when running galasactl resources commands, causing 401 errors when contacting an API server requiring authentication

Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com>
Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com>
@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-230-9qvbj for details. If you are unable to do so, please contact a member of the Galasa team.

Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com>
@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-230-vvhp5 for details. If you are unable to do so, please contact a member of the Galasa team.

@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-230-zzmxz for details. If you are unable to do so, please contact a member of the Galasa team.

Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com>
@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-230-nbf5l for details. If you are unable to do so, please contact a member of the Galasa team.

Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com>
@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-230-x2vpk for details. If you are unable to do so, please contact a member of the Galasa team.

Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com>
@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-230-hkqh8 for details. If you are unable to do so, please contact a member of the Galasa team.

Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com>
Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com>
@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-230-g8vfn for details. If you are unable to do so, please contact a member of the Galasa team.

Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com>
@galasa-team
Copy link

Build successful

@eamansour eamansour merged commit 6e94b00 into main Apr 10, 2024
4 checks passed
@eamansour eamansour deleted the em-remove-temp-auth-code branch April 10, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants