Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI now supports auth tokens filtered by loginId #283

Closed
wants to merge 36 commits into from
Closed

CLI now supports auth tokens filtered by loginId #283

wants to merge 36 commits into from

Conversation

aashir21
Copy link
Contributor

@aashir21 aashir21 commented Sep 13, 2024 •
edited
Loading

@aashir21
CLI now supports tokens filtered by loginId
2ae2cd0 
Signed-off-by: Aashir Siddiqui <aashir_sidiki@hotmail.com>
@aashir21 aashir21 changed the title Iss1976 CLI now supports auth tokens filtered by loginId Sep 13, 2024
@galasa-team
Copy link

Build successful

eamansour
eamansour reviewed Sep 13, 2024
View reviewed changes
pkg/auth/authTokensGet.go Outdated Show resolved Hide resolved
pkg/auth/authTokensGet.go Outdated Show resolved Hide resolved
docs/generated/galasactl_auth_tokens_get.md Outdated Show resolved Hide resolved
pkg/cmd/authTokens.go Outdated Show resolved Hide resolved
pkg/cmd/authTokens.go Outdated Show resolved Hide resolved
pkg/cmd/authTokens.go Outdated Show resolved Hide resolved
pkg/cmd/authTokens.go Outdated Show resolved Hide resolved
pkg/cmd/authTokensGet.go Outdated Show resolved Hide resolved
pkg/auth/authTokensGet.go Outdated Show resolved Hide resolved
pkg/cmd/authTokens.go Outdated Show resolved Hide resolved
@aashir21
Implemented the changes requested
676dd21 
Signed-off-by: Aashir Siddiqui <aashir_sidiki@hotmail.com>
@aashir21
Resolved conflicts
906919f 
Signed-off-by: Aashir Siddiqui <aashir_sidiki@hotmail.com>
@aashir21
Added error msg
edd8753
@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-283-92n8f for details. If you are unable to do so, please contact a member of the Galasa team.

@galasa-team
Copy link

Build successful

aashir21 and others added 19 commits September 18, 2024 09:51
@aashir21
CLI now supports tokens filtered by loginId
89bbd85 
Signed-off-by: Aashir Siddiqui <aashir_sidiki@hotmail.com>
@aashir21
Implemented the changes requested
967d8c8 
Signed-off-by: Aashir Siddiqui <aashir_sidiki@hotmail.com>
@eamansour @aashir21
Update runs get to use cursor-based pagination (#273)
364a909 
* Use cursor-based pagination when getting runs from the API server

Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com>

* Remove includeCursor query parameter

Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com>

* Swap cursor condition order

Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com>

* Turn on includeCursor parameter

Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com>

* Remove log statement

Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com>

* Use 'from:desc' as the default sort for runs get

Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com>

---------

Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com>
Signed-off-by: Aashir Siddiqui <aashir_sidiki@hotmail.com>
@techcobweb @aashir21
JVM launching -D parameters should be passed before the -jar paramete…
27454b1 
…r to have any effect (#275)

Signed-off-by: Mike Cobbett <77053+techcobweb@users.noreply.github.com>
Signed-off-by: Aashir Siddiqui <aashir_sidiki@hotmail.com>
@techcobweb @aashir21
CLI should handle long and multi-line property values better. (#274)
7e0165a 
* handle properties which have newlines or are very long better. Cropping text in the summary view.
* explained away the interesting transform of apiversion to apiVersion in comments
---------
Signed-off-by: Mike Cobbett <77053+techcobweb@users.noreply.github.com>
Signed-off-by: Aashir Siddiqui <aashir_sidiki@hotmail.com>
@jadecarino @aashir21
Add copyright and remove argo app param
e80f286 
Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
Signed-off-by: Aashir Siddiqui <aashir_sidiki@hotmail.com>
@jadecarino @aashir21
Disabling gradle cache to avoid build problems
b9e61dc 
Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
Signed-off-by: Aashir Siddiqui <aashir_sidiki@hotmail.com>
@jadecarino @aashir21
Change the CLI's base image to ubuntu so it has bash
f590606 
Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
Signed-off-by: Aashir Siddiqui <aashir_sidiki@hotmail.com>
@jadecarino @aashir21
Empty commit for build
dca021e 
Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
Signed-off-by: Aashir Siddiqui <aashir_sidiki@hotmail.com>
@jadecarino @aashir21
Remove maven cache
ea2126b 
Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
Signed-off-by: Aashir Siddiqui <aashir_sidiki@hotmail.com>
@aashir21
Signing off commits
9e3868e 
Signed-off-by: Aashir Siddiqui <aashir_sidiki@hotmail.com>
@jadecarino @aashir21
Install ca certs into galasactl images
1097a3c 
Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
Signed-off-by: Aashir Siddiqui <aashir_sidiki@hotmail.com>
@jadecarino @aashir21
change based on comments
874ef86 
Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
Signed-off-by: Aashir Siddiqui <aashir_sidiki@hotmail.com>
@jadecarino @aashir21
Remove isolated trigger - now in Tekton pipeline
2876b32 
Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
Signed-off-by: Aashir Siddiqui <aashir_sidiki@hotmail.com>
@jadecarino @aashir21
testing script adjustments
6b8c585 
Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
Signed-off-by: Aashir Siddiqui <aashir_sidiki@hotmail.com>
@jadecarino @aashir21
test adjusments to remote cps script
3aef41c 
Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
Signed-off-by: Aashir Siddiqui <aashir_sidiki@hotmail.com>
@jadecarino @aashir21
uncomment script
8031bad 
Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
Signed-off-by: Aashir Siddiqui <aashir_sidiki@hotmail.com>
@jadecarino @aashir21
add new image for testing purposes
8b8b1ec 
Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
Signed-off-by: Aashir Siddiqui <aashir_sidiki@hotmail.com>
@jadecarino @aashir21
install java, maven and gradle into normal galasactl image
a84fbef 
Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
Signed-off-by: Aashir Siddiqui <aashir_sidiki@hotmail.com>
jadecarino and others added 9 commits September 18, 2024 09:54
@jadecarino @aashir21
just install gradle for now
b1ecb9d 
Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
Signed-off-by: Aashir Siddiqui <aashir_sidiki@hotmail.com>
@jadecarino @aashir21
empty for build
b153c0e 
Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
Signed-off-by: Aashir Siddiqui <aashir_sidiki@hotmail.com>
@jadecarino @aashir21
Fix problem with script
1060465 
Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
Signed-off-by: Aashir Siddiqui <aashir_sidiki@hotmail.com>
@jadecarino @aashir21
add java_home env var to docker image
fca9a56 
Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
Signed-off-by: Aashir Siddiqui <aashir_sidiki@hotmail.com>
@jadecarino @aashir21
Create new testing image
0faa4f7 
Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
Signed-off-by: Aashir Siddiqui <aashir_sidiki@hotmail.com>
@aashir21
Empty commit to trigger rebuild
9d9e8ca 
Signed-off-by: Aashir Siddiqui <aashir_sidiki@hotmail.com>
@aashir21
Merge branch 'Iss1976' of https://github.com/galasa-dev/cli into Iss1976
2271d2a
@aashir21
Squashed commits
ec7bdfd 
Signed-off-by: Aashir Siddiqui <aashir_sidiki@hotmail.com>
@aashir21
Merge branch 'ash-Iss1976-signed' into Iss1976
6248a06
@galasa-team
Copy link

Build successful

@eamansour
Merge branch 'origin/main' into Iss1976
6ef959e 
Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com>
@galasa-team
Copy link

Build successful

2 similar comments
@galasa-team
Copy link

Build successful

@galasa-team
Copy link

Build successful

eamansour
eamansour reviewed Sep 19, 2024
View reviewed changes
Copy link
Member

@eamansour eamansour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really good! Spotted a few more areas that could be improved :)

pkg/auth/authTokensGet.go Outdated Show resolved Hide resolved
pkg/auth/authTokensGet.go Outdated Show resolved Hide resolved
pkg/auth/authTokensGet_test.go Outdated Show resolved Hide resolved
docs/generated/galasactl_auth_tokens_get.md Outdated Show resolved Hide resolved
pkg/auth/authTokensGet_test.go Outdated Show resolved Hide resolved
pkg/auth/authTokensGet_test.go Show resolved Hide resolved
@aashir21
Implemented the changes requested
ad615a2 
Signed-off-by: Aashir Siddiqui <aashir_sidiki@hotmail.com>
@aashir21
Resolved conflicts
7a33682 
Signed-off-by: Aashir Siddiqui <aashir_sidiki@hotmail.com>
@aashir21
Merge branch 'main' into Iss1976
28b9976
@galasa-team
Copy link

Build successful

@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-283-mnxtw for details. If you are unable to do so, please contact a member of the Galasa team.

@aashir21 aashir21 closed this Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eamansour eamansour eamansour left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aashir21 @galasa-team @eamansour @techcobweb @jadecarino