Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added PR and Main build workflows #251

Merged
merged 24 commits into from
Jul 25, 2024
Merged

Conversation

jaydee029
Copy link
Contributor

jaydee029 and others added 2 commits July 11, 2024 20:57
Signed-off-by: dhruv <dhruvj797@gmail.com>
add pr and build workflows
@galasa-team
Copy link

Automatic triggering of the build is cancelled as user is not a member of the approved groups. Please ask an admin to review this PR and create a comment on the PR stating 'Approved for building'

jaydee029 and others added 2 commits July 14, 2024 17:32
Signed-off-by: dhruv <dhruvj797@gmail.com>
@galasa-team
Copy link

Automatic triggering of the build is cancelled as user is not a member of the approved groups. Please ask an admin to review this PR and create a comment on the PR stating 'Approved for building'

jaydee029 and others added 5 commits July 14, 2024 17:36
Signed-off-by: dhruv <dhruvj797@gmail.com>
Signed-off-by: dhruv <dhruvj797@gmail.com>
Signed-off-by: dhruv <dhruvj797@gmail.com>
Signed-off-by: dhruv <dhruvj797@gmail.com>
@galasa-team
Copy link

Automatic triggering of the build is cancelled as user is not a member of the approved groups. Please ask an admin to review this PR and create a comment on the PR stating 'Approved for building'

@jaydee029
Copy link
Contributor Author

For the Main build I am facing an error, here

image

jaydee029 and others added 4 commits July 24, 2024 17:03
Signed-off-by: dhruv <dhruvj797@gmail.com>
Signed-off-by: dhruv <dhruvj797@gmail.com>
added recommended changes
@jaydee029 jaydee029 marked this pull request as ready for review July 24, 2024 11:47
@galasa-team
Copy link

Automatic triggering of the build is cancelled as user is not a member of the approved groups. Please ask an admin to review this PR and create a comment on the PR stating 'Approved for building'

1 similar comment
@galasa-team
Copy link

Automatic triggering of the build is cancelled as user is not a member of the approved groups. Please ask an admin to review this PR and create a comment on the PR stating 'Approved for building'

jaydee029 and others added 3 commits July 24, 2024 17:30
Signed-off-by: dhruv <dhruvj797@gmail.com>
Signed-off-by: dhruv <dhruvj797@gmail.com>
@galasa-team
Copy link

Automatic triggering of the build is cancelled as user is not a member of the approved groups. Please ask an admin to review this PR and create a comment on the PR stating 'Approved for building'

jaydee029 and others added 2 commits July 24, 2024 17:50
Signed-off-by: dhruv <dhruvj797@gmail.com>
@galasa-team
Copy link

Automatic triggering of the build is cancelled as user is not a member of the approved groups. Please ask an admin to review this PR and create a comment on the PR stating 'Approved for building'

jaydee029 and others added 2 commits July 24, 2024 19:36
Signed-off-by: dhruv <dhruvj797@gmail.com>
@galasa-team
Copy link

Automatic triggering of the build is cancelled as user is not a member of the approved groups. Please ask an admin to review this PR and create a comment on the PR stating 'Approved for building'

Copy link
Contributor

@jadecarino jadecarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more changes needed to the build.gradle files - please see the changes in the last two files in this PR here: https://github.com/galasa-dev/extensions/pull/253/files#diff-89f14a49ae148ebe686cf58bf66f03fb36718b5ba1c103d8490dd3ce23ef388b

.github/workflows/build.yaml Outdated Show resolved Hide resolved
.github/workflows/build.yaml Show resolved Hide resolved
jaydee029 and others added 2 commits July 25, 2024 15:41
Signed-off-by: dhruv <dhruvj797@gmail.com>
added requested changes
@galasa-team
Copy link

Automatic triggering of the build is cancelled as user is not a member of the approved groups. Please ask an admin to review this PR and create a comment on the PR stating 'Approved for building'

jaydee029 and others added 2 commits July 25, 2024 15:46
Signed-off-by: dhruv <dhruvj797@gmail.com>
added requested changes
@galasa-team
Copy link

Automatic triggering of the build is cancelled as user is not a member of the approved groups. Please ask an admin to review this PR and create a comment on the PR stating 'Approved for building'

Copy link
Contributor

@jadecarino jadecarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for building

@galasa-team
Copy link

Build successful

@jadecarino jadecarino merged commit ad727f6 into galasa-dev:main Jul 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants