Stop loading artifacts when deleting runs, fix potential NullPointerException #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…carding runs, unit tests Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com>
|
Build successful |
1 similar comment
|
Build successful |
Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com>
eamansour
force-pushed
the
iss1210-delete-runs-performance
branch
from
aad4547
to
c1d0b05
Compare
|
Build successful |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
See galasa-dev/projectmanagement#1210
Deleting runs from the Galasa service is much slower than it should be because it loads all attached artifacts for a run into a filesystem when fetching a run by its ID. This work is unnecessary when deleting runs since we only care about IDs of the documents to delete related to the run (i.e. log documents, artifact documents, and the run document itself).
Changes