Replace page-based pagination with cursor-based pagination in /ras/runs #627
+92
−366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful |
1 similar comment
|
Build successful |
eamansour
force-pushed
the
iss1921-runs-get-performance
branch
from
9c36b41
to
4738170
Compare
|
Build successful |
techcobweb
approved these changes
Aug 28, 2024
Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com>
Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com>
Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com>
eamansour
force-pushed
the
iss1921-runs-get-performance
branch
from
4738170
to
9389e26
Compare
|
Build successful |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
See galasa-dev/projectmanagement#1921
Changes
/ras/runsAPI due to its poor performance and replaced it with cursor-based pagination that was temporarily made available using theincludeCursorquery parameterpageandincludeCursorquery parameters from/ras/runsNote: Once this PR is delivered, clients using the old
/ras/runsAPI will need to switch to using cursor-based pagination by retrieving thenextCursorvalue in responses and supplying that value in subsequent requests using thecursorquery parameter (as described in thecursorquery parameter's OpenAPI description).