Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added build log generation/uploading #200

Merged
merged 4 commits into from
Aug 22, 2024
Merged

Conversation

Signed-off-by: dhruv <dhruvj797@gmail.com>
@galasa-team
Copy link

Automatic triggering of the build is cancelled as user is not a member of the approved groups. Please ask an admin to review this PR and create a comment on the PR stating 'Approved for building'

Copy link
Contributor

@jadecarino jadecarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor changes for clarity and as with the other PRs, please can we change the upload artefacts to only happen on failure, and add the same into the PR builds, both with a retention period of 7 days

.github/workflows/build.yaml Outdated Show resolved Hide resolved
.github/workflows/build.yaml Outdated Show resolved Hide resolved
Signed-off-by: dhruv <dhruvj797@gmail.com>
@galasa-team
Copy link

Automatic triggering of the build is cancelled as user is not a member of the approved groups. Please ask an admin to review this PR and create a comment on the PR stating 'Approved for building'

Signed-off-by: dhruv <dhruvj797@gmail.com>
@jaydee029
Copy link
Contributor Author

A couple of minor changes for clarity and as with the other PRs, please can we change the upload artefacts to only happen on failure, and add the same into the PR builds, both with a retention period of 7 days

done

@galasa-team
Copy link

Automatic triggering of the build is cancelled as user is not a member of the approved groups. Please ask an admin to review this PR and create a comment on the PR stating 'Approved for building'

Signed-off-by: dhruv <dhruvj797@gmail.com>
@galasa-team
Copy link

Automatic triggering of the build is cancelled as user is not a member of the approved groups. Please ask an admin to review this PR and create a comment on the PR stating 'Approved for building'

Copy link
Contributor

@jadecarino jadecarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for building

@galasa-team
Copy link

Build successful

@jadecarino jadecarino merged commit d3f1799 into galasa-dev:main Aug 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants