Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

I1 #894

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

I1 #894

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
*/
package dev.galasa.cicsts.cicsresource;



/**
* Represents a CICS Bundle resource. It provides methods to set CICS Bundle specific attributes on the resource
* (via CEDA) and to manage and set attributes in CEMT
Expand Down Expand Up @@ -47,14 +49,15 @@ public interface ICicsBundle {

/**
* Return the CICS BUNDLE resource BUNDLEDIR attribute value
* @return the resource JVMPROFILE attribute value
* @return the resource BundleDirectory
*/
public String getResourceDefinitionBundledirAttribute();

/**
* Build the complete JVM server including the profile zOS UNIX file and the CICS resource definition. This method will install the CICS
* Build the complete CICS Bundle CICS resource definition. This method will install the CICS
* resource and wait for it to become enabled
* @throws CicsBundleResourceException
* @throws TestBundleResourceException
*/
public void build() throws CicsBundleResourceException;

Expand Down Expand Up @@ -186,5 +189,8 @@ public interface ICicsBundle {
* Returns the CICS BUNDLE name as defined in the CICS Resource Definition
* @return the CICS BUNDLE name
*/
public String getName();
public String getDefinitionName();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally, you'd deprecate the public interface method, rather than renaming/removing it.

How sure are we that nobody is going to break as a result of this change ?
Could any of the Galasa users out there be using this interface ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for building




}
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
*/
public interface ICicsResource {


/**
* Create a CICS BUNDLE resource object supplying the CICS bundle content.
*
Expand All @@ -26,11 +27,13 @@ public interface ICicsResource {
* @param name the CICS BUNDLE RDO name
* @param group the CICS BUNDLE RDO group name
* @param bundlePath the path to the directory in the test class bundle containing the CICS bundle
* @param parameters substitution parameters to replace variables in the <code>META-INF/cics.xml</code>. Can be <code>null</code>
* @param bundleDir the path to an existing bundle already on zfs
* @param parameters substitution parameters to replace variables in the bundle parts
* @param skeletonType Velocity = 1, PlusPlus = 0
* @return the CICS Bundle object
* @throws CicsBundleResourceException
*/
public ICicsBundle newCicsBundle(ICicsTerminal cicsTerminal, Class<?> testClass, String name, String group, String bundlePath, Map<String, String> parameters) throws CicsBundleResourceException;
public ICicsBundle newCicsBundle(ICicsTerminal cicsTerminal, Class<?> testClass, String name, String group, String bundlePath,String bundleDir, Map<String, Object> parameters,int skeletonType) throws CicsBundleResourceException;

/**
* Create a CICS BUNDLE resource object without supplying the CICS bundle content, i.e. the bundle already exists on the zOS UNIX file system
Expand Down Expand Up @@ -102,4 +105,6 @@ public interface ICicsResource {
* @return the JVM profile
*/
public IJvmprofile newJvmprofile(String jvmprofileName, String content);


}
Loading