Exposes job.PriorityClass.value as modifiable value #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afgane
reviewed
Feb 15, 2024
Updated description according to afgane's input. Co-authored-by: Enis Afgan <afgane@gmail.com>
nuwang
reviewed
Feb 15, 2024
| preemptionPolicy: Never | ||
| globalDefault: false | ||
| description: "Galaxy jobs will run when cluster resources are available and will not preempt existing workloads." | ||
| description: "By default, Galaxy jobs will not preempt existing workloads but will run when cluster resources are available. Depending on the cluster setup, the preemption value can be modified to prompt scaling of the cluster for the computation." |
There was a problem hiding this comment.
I think some guidance on what values would elicit the desired behaviour in the autoscaler case would also be helpful. That is to say, at what priority value would the autoscaler scale up and schedule nodes?
There was a problem hiding this comment.
Thank you, sounds great!
Simplifying if/else by default as suggested by nuwang. Co-authored-by: Nuwan Goonasekera <2070605+nuwang@users.noreply.github.com>
nuwang
reviewed
Feb 15, 2024
Fixing last line chomp. Co-authored-by: Nuwan Goonasekera <2070605+nuwang@users.noreply.github.com>
nuwang
approved these changes
Feb 16, 2024
|
@mapk-amazon Thanks for this! Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses this issue.
#450