Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macros detection condition #239

Merged
merged 4 commits into from
Aug 29, 2023
Merged

Fix macros detection condition #239

merged 4 commits into from
Aug 29, 2023

Conversation

davelopez
Copy link
Collaborator

Fixes #234

The expanded version of the tool source was only passed to the Galaxy linter when an expand tag was present in the unexpanded tool source. This change considers other macro-related tags to ensure the expanded version is linted when necessary.

@davelopez davelopez added bug Something isn't working language server Related to the language server labels Aug 28, 2023
@davelopez davelopez added this to the v0.11.0 milestone Aug 28, 2023
@bgruening
Copy link
Member

Thanks!

@davelopez davelopez merged commit 72a4a44 into main Aug 29, 2023
8 checks passed
@davelopez davelopez deleted the fix_macros_detection branch August 29, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working language server Related to the language server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

linting complains about our tool version recommendations
2 participants