Version query parameter not working for Dockstore/TRS import

[coverbeck]

Dockstore is implementing a Launch with Galaxy button. When we specify the version, using the trs_version query parameter, the Galaxy UI shows an error, and you are prompted which version to select. The expected behavior is that Galaxy should import the specified version.

To reproduce, go to https://usegalaxy.org/workflows/trs_import?trs_server=dockstore.org&trs_id=%23workflow/github.com/jmchilton/galaxy-workflow-dockstore-example-1/mycoolworkflow&trs_version=master

Also see discussion on Dockstore issue.

Tangential Issue

Let me know if I should log this separately. We'd like to specify a different Dockstore server for testing purposes. We have our daily build and staging environments. When we specify ...?trs_server=dev.dockstore.net&..., an error pops up briefly and Galaxy seems to read from dockstore.org. Is this supposed to work?

[mvdbeek]

When we specify ...?trs_server=dev.dockstore.net&..., an error pops up briefly and Galaxy seems to read from dockstore.org. Is this supposed to work?

It is, but we need to add dev.dockstore.net to the enabled and validated trs server list, I will make sure we enable this for usegalaxy.org / test.galaxyproject.org.

The version handling seems slightly off, I'll have a fix shortly.

[coverbeck]

It is, but we need to add dev.dockstore.net to the enabled and validated trs server list, I will make sure we enable this for usegalaxy.org / test.galaxyproject.org.

Great! While you're doing that, could you please add our staging environment as well, staging.dockstore.org? So 3 total:

• dockstore.org
• staging.dockstore.org
• dev.dockstore.net

Thanks!

[mvdbeek]

OK, so this is a discrepancy between what workflowhub.eu defines as the "trs_version". For workflowhub.eu, this is what matches the id field, while for dockstore.org this matches the name. The name field looks better to me, since it actually contains the user-defined version of the workflow, but it would be great if this can be synced up (@bedroesb @bgruening you have workflowhub connections, right ?).

This is the workflowhub.eu:

This is dockstore.org:

I'm just gonna allow both for now, but this should really be resolved.

[bgruening]

This is just poorly defined in the spec and its not clear for the workfowhub people. @coverbeck this is the related issue: ga4gh/tool-registry-service-schemas#153

On usegalaxy.eu we ship actually a patch to support both version.

[coverbeck]

Ah, right, thanks, I remember that ticket now @bgruening.

[bgruening]

Your welcome! Thanks for looking into it!

[mvdbeek]

Alright, #12021 fixed the query parameter, and I've enabled dev and staging servers on https://test.galaxyproject.org/. Thanks for the report @coverbeck!