[21.05] Allow trs_version to refer to name or id field #12021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdbeek
force-pushed
the
allow_trs_version_id_to_be_name_or_id_field
branch
from
57c9777 to
9736d53
Compare
|
nice! @mvdbeek |
OlegZharkov
reviewed
May 20, 2021
| Should just be one of them eventually. */ | ||
| let versionField = "name"; | ||
| const version = this.trsTool.versions.find((version) => { | ||
| if (version.name == this.queryTrsVersionId) { |
There was a problem hiding this comment.
I get a warning on my IDE to use === instead of ==, but I guess it doesn't matter 😅
There was a problem hiding this comment.
Yeah, meant to do triple, I'll push a fix
OlegZharkov
approved these changes
May 20, 2021
This has diverged between workflowhub.eu and dockstore implementations.
mvdbeek
force-pushed
the
allow_trs_version_id_to_be_name_or_id_field
branch
from
9736d53 to
41ab4d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has diverged between workflowhub.eu and dockstore implementations.
What did you do?
Why did you make this change?
Works around #12017 (comment)
How to test the changes?
(select the most appropriate option; if the latter, provide steps for testing below)
for dockstore:
<galaxy_url>/workflows/trs_import?trs_server=dockstore.org&run_form=true&trs_id=%23workflow/github.com/jmchilton/galaxy-workflow-dockstore-example-1/mycoolworkflow&trs_version=master
for workflowhub:
<galaxy_url>/workflows/trs_import?trs_server=workflowhub.eu&run_form=true&trs_id=111&trs_version=2
License
For UI Components