Add count support for listing filters #16075
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdbeek
reviewed
May 12, 2023
Allows to get the total_matches of a query (without offset or limit) to be able to handle pagination in a deterministic way.
The existing functional filters should be either translated to ORM filters or dropped. They won't be supported in count.
This test file is full of them, and it is probably better to split all of them into their own test cases but it will require a bigger refactoring...
davelopez
force-pushed
the
add_item_listing_count
branch
from
652b5a1 to
0c3ee1a
Compare
4 tasks
4 tasks
jmchilton
approved these changes
May 23, 2023
Member
|
Thanks @davelopez |
Contributor
Author
|
Thanks for the reviews and merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #16003
I figured out that could be useful when trying to get the
total_matchesof a query using the current "dynamic filtering framework", not sure why it was not part of the API already, maybe because using functional filters could impact the performance in some extreme cases? We probably could fail the request as we do currently when listing history contents.In draft until both TODOs are resolved.
How to test the changes?
License