Improve histories and datasets immutability checks #16143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davelopez
added
kind/enhancement
kind/refactoring
4 tasks
jdavcs
reviewed
May 24, 2023
Avoids some mutation operations through the API on items that are purged or archived.
davelopez
force-pushed
the
improve_history_immutability_checks
branch
from
bc1d610 to
4cc9d48
Compare
davelopez
force-pushed
the
improve_history_immutability_checks
branch
from
66fcbb6 to
5837ae4
Compare
Contributor
Author
|
I made checks for immutability in most of the places it seemed sensible to and added a bunch of tests trying to modify immutable histories and datasets belonging to these histories, running jobs, workflows, etc and it seems to work fine. Of course, I may have missed other important locations so someone with 🦅 👁️ is very much appreciated 😊 |
mvdbeek
approved these changes
May 25, 2023
Member
mvdbeek
left a comment
mvdbeek
left a comment
There was a problem hiding this comment.
I don't think it's critical that we hit all the spots, so this looks great!
Contributor
Author
|
Thank you Marius! I will merge then! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #16003
Restricts some mutation operations through the API on items that are purged or archived. This is probably not enforced thoroughly enough, but it should work for a significant number of situations that are already inconsistent.
For example, you can no longer drag and drop or copy datasets to a purged history.
TODO:
How to test the changes?
License