Workflow Invocation view improvements #18615
Open
+863
−865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmedhamidawan
force-pushed
the
invocation_view_improvements
branch
from
b4cdf6b
to
feb4bf9
Compare
ahmedhamidawan
force-pushed
the
invocation_view_improvements
branch
from
feb4bf9
to
ea4fcb4
Compare
ahmedhamidawan
force-pushed
the
invocation_view_improvements
branch
from
be8f9b6
to
b7a0424
Compare
This first commit tackles point A in the roadmap: List of invocations is now not visible continously, it goes away after you settle on one invocation and `mouseleave` the panel area. Roadmap: https://hackmd.io/@nekrut/HkinoEh8A
- Instead of showing steps right next to the invocation graph, moves steps (back) into a separate tab - To make this work, adds a `graphStepsByStoreId` to the `invocationStore` that helps access the graph steps in multiple components (TODO: improve how this is done) - Instead of clicking on a node/step in the graph and showing the job for the step that the user clicks, now we show the whole expanded step below
add gap between step header buttons
remove `JobStepTabs.vue`
ahmedhamidawan
force-pushed
the
invocation_view_improvements
branch
from
d5ac101
to
0841ef9
Compare
- The progress bars are in `WorkflowInvocationHeader` now, giving more space to the step header being visible below the graph - `WorkflowRunSuccess` is a one line header (refactored), and it uses `GridInvocation` to show batch invocations.
ahmedhamidawan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following discussions at GCC 2024 and this roadmap by @nekrut: https://hackmd.io/@nekrut/HkinoEh8A
Overall Change to the component
OverviewtabChanges to an actively running workflow
Changes made to
WorkflowRunSuccess:Other Changes
Changes from the roadmap and other changes that improve the UX:
- Steps moved to a separate tab, show clicked/active step below instead of job
This removes the steps from the overview and the graph is filling the center as the default view, and instead of clicking a step and then viewing a job below, the active/clicked step is shown below in its entirety:
invocation_graph_steps_removed.mp4
- Improved Workflow Invocation Step component
- Inputs shown in Graph
- Invocation Panel toggles out on
mouseleaveThe first commit tackles point A in the roadmap: List of invocations is now not visible continously, it goes away after you settle on one invocation and
mouseleavethe panel area:How to test the changes?
(Select all options that apply)
License