[24.0] Fix discovered outputs with directory metadata and distributed object #18855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stores The problem is that `object_store.is_private` would check in which object store the dataset is stored, and that fails if we haven't written to the object store yet (which is why extended metadata is a workaround). Fixes galaxyproject#17208
|
Test failures should be unrelated |
jmchilton
approved these changes
Sep 19, 2024
|
I think this broke a bunch of integration tests when merged forward in 24.1 and dev, see e.g. https://github.com/galaxyproject/galaxy/actions/runs/10954644522 |
|
Yes, working on it. |
Thanks! |
mvdbeek
added a commit
to mvdbeek/galaxy
that referenced
this pull request
Sep 23, 2024
Fixes galaxyproject#18855 (comment). I don't think this had any effect in the previous version since we'd always set the state to final_job_state anyway.
4 tasks
mvdbeek
added a commit
to mvdbeek/galaxy
that referenced
this pull request
Sep 23, 2024
Fixes galaxyproject#18855 (comment). I don't think this had any effect in the previous version since we'd always set the state to final_job_state anyway.
mvdbeek
added a commit
that referenced
this pull request
Sep 23, 2024
Fixes #18855 (comment). I don't think this had any effect in the previous version since we'd always set the state to final_job_state anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stores
The problem is that
object_store.is_privatewould check in which object store the dataset is stored, and that fails if we haven't written to the object store yet (which is why extended metadata is a workaround).Fixes #17208
How to test the changes?
(Select all options that apply)
License