Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always validate hashes when provided #19110

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

nsoranzo
Copy link
Member

@nsoranzo nsoranzo commented Nov 5, 2024

Currently when uploading datasets with associated hashes, this were only validated if validate_hashes=True was also passed in the request.

This commit drops validate_hashes completely and always validates hashes when they were provided.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Currently when uploading datasets with associated hashes, this were
only validated if `validate_hashes=True` was also passed in the
request.

This commit drops `validate_hashes` completely and always validates
hashes when they were provided.
@nsoranzo
Copy link
Member Author

nsoranzo commented Nov 6, 2024

Integration test failure unrelated.

Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

@mvdbeek
Copy link
Member

mvdbeek commented Nov 7, 2024

@jmchilton are ok with this ?

@jmchilton
Copy link
Member

I'm +0 on it, feel free to merge.

@nsoranzo nsoranzo merged commit eb7d89d into galaxyproject:dev Nov 7, 2024
57 of 58 checks passed
@nsoranzo nsoranzo deleted the always_validate_hashes branch November 7, 2024 19:25
@nsoranzo
Copy link
Member Author

nsoranzo commented Nov 7, 2024

Thanks @jmchilton !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants