Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a posix file source to prefer linking. #19132

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

jmchilton
Copy link
Member

The linking upload parameters will still be respected, but if none of them are set data fetch will default to just linking files during upload. This uses Dataset.external_filename instead of symlinks in the objectstore so that Galaxy has better tracking of the links and so this works closer to the way data libraries have always worked.

Alternative to #19125.

How to test the changes?

(Select all options that apply)

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@jmchilton jmchilton force-pushed the posix_prefer_links branch 2 times, most recently from e0fc1d0 to 4aad8ca Compare November 12, 2024 16:04
The linking upload parameters will still be respected, but if none of them are set data fetch will default to just linking files during upload. This uses Dataset.external_filename instead of symlinks in the objectstore so that Galaxy has better tracking of the links and so this works closer to the way data libraries have always worked.
@jmchilton jmchilton marked this pull request as ready for review November 12, 2024 21:32
@github-actions github-actions bot added this to the 25.0 milestone Nov 12, 2024
@guerler
Copy link
Contributor

guerler commented Nov 13, 2024

Thank you @jmchilton. I tried this and ran into an issue. The upload works fine and the dataset looks good but when attempting to run a job with that linked dataset the tool cannot find the input file.

@jmchilton
Copy link
Member Author

I've added a test case for running a tool afterward and it works fine... I'm going to have to gulp... use Galaxy... aren't I?

@jmchilton
Copy link
Member Author

It worked fine for me. Details below.

Did this not work on your laptop or on a cluster? Can you confirm the external_filename points at a valid path after the upload? Are any parent directories of the external_filename symbolic links - I've had problems with /private/tmp vs /tmp when using Docker for instance.

Uploaded Dataset:

Screenshot 2024-11-13 at 10 09 48 AM

After running a tool on it:

Screenshot 2024-11-13 at 10 10 03 AM

Config:

- id: home_directory
  label: Home Directory
  doc: Your Home Directory on this System
  type: posix
  root: "/Users/jxc755/"
  prefer_links: true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants