Remove transaction helper from tool_shed.metadata

lib/tool_shed/metadata/repository_metadata_manager.py

@@ -13,7 +13,6 @@
 )
 
 from galaxy import util
-from galaxy.model.base import transaction
 from galaxy.tool_shed.metadata.metadata_generator import (
     BaseMetadataGenerator,
     HandleResultT,
@@ -270,8 +269,7 @@ def _add_tool_versions(self, id: int, repository_metadata, changeset_revisions):
             repository_metadata.tool_versions = tool_versions_dict
             self.sa_session.add(repository_metadata)
             session = self.sa_session()
-            with transaction(session):
-                session.commit()
+            session.commit()
 
     def build_repository_ids_select_field(
         self, name="repository_ids", multiple=True, display="checkboxes", my_writable=False
@@ -297,8 +295,7 @@ def _clean_repository_metadata(self, changeset_revisions):
             if changeset_revision not in changeset_revisions:
                 self.sa_session.delete(repository_metadata)
                 session = self.sa_session()
-                with transaction(session):
-                    session.commit()
+                session.commit()
 
     def compare_changeset_revisions(self, ancestor_changeset_revision, ancestor_metadata_dict):
         """
@@ -524,8 +521,7 @@ def create_or_update_repository_metadata(self, changeset_revision, metadata_dict
         repository_metadata.missing_test_components = False
         self.sa_session.add(repository_metadata)
         session = self.sa_session()
-        with transaction(session):
-            session.commit()
+        session.commit()
 
         return repository_metadata
 
@@ -908,8 +904,7 @@ def _reset_all_tool_versions(self, repo):
                 repository_metadata.tool_versions = tool_versions_dict
                 self.sa_session.add(repository_metadata)
                 session = self.sa_session()
-                with transaction(session):
-                    session.commit()
+                session.commit()
 
     def reset_metadata_on_selected_repositories(self, **kwd):
         """
@@ -1021,8 +1016,7 @@ def set_repository_metadata(self, host, content_alert_str="", **kwd):
                     repository_metadata.missing_test_components = False
                     self.sa_session.add(repository_metadata)
                     session = self.sa_session()
-                    with transaction(session):
-                        session.commit()
+                    session.commit()
                 else:
                     # There are no metadata records associated with the repository.
                     repository_metadata = self.create_or_update_repository_metadata(