Run tests on PR branch not main

[paulzierep]

According to actions/checkout#1325
this should check out to the branch used on the PR or the push event. So actually testing what is incoming.

[bebatut]

I think we do not even need the checkout there

[paulzierep]

are you sure ? do you mean it's the PRs repository content by default ?

[bebatut]

are you sure ? do you mean it's the PRs repository content by default ?

I am not 100% sure tbh
In the documentation of checkout, it seems that if we put nothing it should take the PR: https://github.com/actions/checkout?tab=readme-ov-file#checkout-pull-request-on-closed-event

[bebatut]

So we would not need to change anything (except the name the step)

[bebatut]

We should probably change on with:

on:
  push:
    branches:
      - main
      - master
  pull_request:
    branches: [main]
    types: [opened, synchronize, closed]

[paulzierep]

are you sure ? do you mean it's the PRs repository content by default ?

I am not 100% sure tbh In the documentation of checkout, it seems that if we put nothing it should take the PR: https://github.com/actions/checkout?tab=readme-ov-file#checkout-pull-request-on-closed-event

I am confused, so you would leave the checkout but without with ? thats what we got now, no ? and that does not really work

[paulzierep]

are you sure ? do you mean it's the PRs repository content by default ?

I am not 100% sure tbh In the documentation of checkout, it seems that if we put nothing it should take the PR: https://github.com/actions/checkout?tab=readme-ov-file#checkout-pull-request-on-closed-event

I am confused, so you would leave the checkout but without with ? thats what we got now, no ? and that does not really work

mhh from the docs it seems as if you are right, but that: https://github.com/galaxyproject/galaxy_codex/actions/runs/11231597142 should have failed then ...

[bebatut]

It fails there: #187

[paulzierep]

It fails there: #187

Jup, but that's again the error from the column form the last PR, which is now merged in main, actually proofing that this CI did run on main, not the PR

[bebatut]

Do we then need this PR?

[paulzierep]

Do we then need this PR?

Yes, I think it is still the case that the CI as is runs on the main branch not the PR branch, hence not testing anything, I assume that this PR will fix it.