Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to fix community wf triggering #57

Closed
wants to merge 1 commit into from
Closed

Try to fix community wf triggering #57

wants to merge 1 commit into from

Conversation

bebatut
Copy link
Member

@bebatut bebatut commented Feb 12, 2024

No description provided.

@paulzierep
Copy link
Collaborator

this used to work for the static CI. I think it stopped when I removed the branch filter.
it seems that one needs to specifc a branch (maybe also wildcard works)
Could not find anything about it in the docs.

  push:
    branches: ["main"]

@nsoranzo
Copy link
Member

I think the reason is that the fetch-all-tools-merge job in .github/workflows/fetch_all_tools.yaml is using the default GITHUB_TOKEN when doing the git push instead of ${{ secrets.GH_API_TOKEN }} .
Because of this, no further workflow is triggered, see https://docs.github.com/en/actions/using-workflows/triggering-a-workflow#triggering-a-workflow-from-a-workflow for details.

I can open a PR to fix this, if you like.

nsoranzo added a commit to nsoranzo/galaxy_codex that referenced this pull request Feb 26, 2024
@nsoranzo
Use personal access token for git push
1804eb5 
in fetch-all-tools-merge job, so it can trigger the "Filter community tools"
workflow. See https://docs.github.com/en/actions/using-workflows/triggering-a-workflow#triggering-a-workflow-from-a-workflow

Closes galaxyproject#57 .
nsoranzo added a commit to nsoranzo/galaxy_codex that referenced this pull request Feb 26, 2024
@nsoranzo
Use personal access token for git push
8ba7f71 
in fetch-all-tools-merge job, so it can trigger the "Filter community tools"
workflow. See https://docs.github.com/en/actions/using-workflows/triggering-a-workflow#triggering-a-workflow-from-a-workflow

Closes galaxyproject#57 .

Also use the automatic GITHUB_TOKEN for the fetch-all-tools-stepwise job.
nsoranzo added a commit to nsoranzo/galaxy_codex that referenced this pull request Feb 26, 2024
@nsoranzo
Use personal access token for git push
14f55a5 
in fetch-all-tools-merge job, so it can trigger the "Filter community tools"
workflow. See https://docs.github.com/en/actions/using-workflows/triggering-a-workflow#triggering-a-workflow-from-a-workflow

Closes galaxyproject#57 .
@nsoranzo nsoranzo mentioned this pull request Feb 27, 2024
Closed
nsoranzo added a commit to nsoranzo/galaxy_codex that referenced this pull request Mar 4, 2024
@nsoranzo
Use personal access token for git push
74b9a72 
in fetch-all-tools-merge job, so it can trigger the "Filter community tools"
workflow. See https://docs.github.com/en/actions/using-workflows/triggering-a-workflow#triggering-a-workflow-from-a-workflow

Closes galaxyproject#57 .
@paulzierep
Copy link
Collaborator

fixed with: #66

@paulzierep paulzierep closed this Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bebatut @paulzierep @nsoranzo