Enable unity licensing server for Windows #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
webbertakken
approved these changes
Mar 15, 2024
| if (!(process.env.UNITY_EMAIL && process.env.UNITY_PASSWORD)) { | ||
| throw new Error(`Unity email and password must be set for Windows based builds to | ||
| authenticate the license. Make sure to set them inside UNITY_EMAIL | ||
| if (!((process.env.UNITY_EMAIL && process.env.UNITY_PASSWORD) || buildParameters.unityLicensingServer)) { |
There was a problem hiding this comment.
Perhaps it would be helpful to simplify the if statement by adding something like
const { unityLicensingServer } = buildParameters
const hasValidLicensingCredentials = process.env.UNITY_EMAIL && process.env.UNITY_PASSWORD
const hasValidLicensingStrategy = validLicensingCredentials || unityLicensingServer
if (!hasValidLicensingStrategy) { /* stuff */ }There was a problem hiding this comment.
Agreed, I've added these variables for clarification.
We have tested this in our private repo and it works as intended (basically identical to the linux version) |
|
Hello @webbertakken , if any other changes are needed, I'd be glad to discuss or implement them. |
webbertakken
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
A simple version of unity licensing server support for Windows using the same logic as the existing Linux implementation.
Changes
activate.ps1andreturn_license.ps1to replicate what is done inactivate.shandreturn_license.shvalidate-windows.tsto allow this option to pass through for a Windows builddocker.tsto correctly copy the unity config file necessary for unity licensing server requestRelated PRs
Checklist
code of conduct
in the documentation repo)