Skip to content

Commit

Permalink
bug fix
Browse files Browse the repository at this point in the history
  • Loading branch information
hrmoh committed Dec 8, 2023
1 parent 656c909 commit 9c572d0
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 4 deletions.
3 changes: 2 additions & 1 deletion lib/forms/main-form-sections/recitations_data_section.dart
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,8 @@ class _RecitationsState extends State<RecitationsDataSection> {

Future _doEdit(int index) async {
final result = await _edit(widget.narrations.items![index]);
bool reject = result!.reviewStatus == AudioReviewStatus.rejected &&
if (result == null) return;
bool reject = result.reviewStatus == AudioReviewStatus.rejected &&
((widget.narrations.items![index].reviewStatus == 0) ||
(widget.narrations.items![index].reviewStatus == 1));

Expand Down
10 changes: 7 additions & 3 deletions lib/forms/narration_edit.dart
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,9 @@ class _NarrationEditState extends State<NarrationEdit>

@override
void dispose() {
_player!.dispose();
if (_player != null) {
_player!.dispose();
}
_titleController.dispose();
_artistNameController.dispose();
_artistUrlController.dispose();
Expand All @@ -55,6 +57,7 @@ class _NarrationEditState extends State<NarrationEdit>
}

String getVerse(RecitationViewModel narration, Duration position) {
if (narration.verses == null) return '';
var verse = narration.verses!.lastWhere(
(element) => element.audioStartMilliseconds <= position.inMilliseconds);
return verse.verseText;
Expand Down Expand Up @@ -178,11 +181,11 @@ class _NarrationEditState extends State<NarrationEdit>
ControlButtons(_player!, widget.narration,
widget.loadingStateChanged, widget.snackbarNeeded),
StreamBuilder<Duration?>(
stream: _player!.durationStream,
stream: _player?.durationStream,
builder: (context, snapshot) {
final duration = snapshot.data ?? Duration.zero;
return StreamBuilder<Duration>(
stream: _player!.positionStream,
stream: _player?.positionStream,
builder: (context, snapshot) {
var position = snapshot.data ?? Duration.zero;
if (position > duration) {
Expand All @@ -196,6 +199,7 @@ class _NarrationEditState extends State<NarrationEdit>
duration: duration,
position: position,
onChangeEnd: (newPosition) {
if (_player == null) return;
_player!.seek(newPosition);
},
),
Expand Down

0 comments on commit 9c572d0

Please sign in to comment.