Skip to content

Require setup-gap@v3 to simplify some code #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wilfwilson merged 1 commit into from
Sep 4, 2025
Merged

Require setup-gap@v3 to simplify some code #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
- uses: actions/checkout@v5
with:
path: this-action/
- uses: gap-actions/setup-gap@v2
- uses: gap-actions/setup-gap@v3
- uses: ./this-action/
with:
use-latex: ${{ matrix.use-latex }}
Expand Down
12 changes: 8 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@ All of the following inputs are optional.
treated as errors
- default: `true`

### What's new in v2

This action now requires `gap-actions/setup-gap@v3`.

### Examples

See below for
Expand All @@ -49,8 +53,8 @@ jobs:

steps:
- uses: actions/checkout@v5
- uses: gap-actions/setup-gap@v2
- uses: gap-actions/build-pkg-docs@v1
- uses: gap-actions/setup-gap@v3
- uses: gap-actions/build-pkg-docs@v2
```

#### Uploading the manual as an artifact
Expand All @@ -70,8 +74,8 @@ jobs:

steps:
- uses: actions/checkout@v5
- uses: gap-actions/setup-gap-for-packages@v2
- uses: gap-actions/build-pkg-docs@v1
- uses: gap-actions/setup-gap@v3
- uses: gap-actions/build-pkg-docs@v2
with:
use-latex: 'true'
- name: 'Upload documentation'
Expand Down
16 changes: 0 additions & 16 deletions action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,22 +19,6 @@ runs:
run: |
sudo apt-get update
sudo apt-get install --no-install-recommends texlive-latex-base texlive-latex-recommended texlive-latex-extra texlive-fonts-recommended
- name: "Setup GAP root"
shell: bash
run: |
# set up a custom GAP root containing only this package, so that
# we can force GAP to load the correct version of this package
# (we already did that in build_pkg.sh, but we do it again here,
# to allow the occasional instance where a package wants to also
# run the tests of others packages, by invoking this script multiple
# times in different directories)
mkdir -p /tmp/gaproot/pkg/
ln -f -s $PWD /tmp/gaproot/pkg/

# start GAP with custom GAP root, to ensure correct package version is loaded
GAPROOT=${GAPROOT-$HOME/gap}
echo "GAP=$GAPROOT/gap -l /tmp/gaproot; --quitonbreak" >> "$GITHUB_ENV"
echo "GAPROOT=$GAPROOT" >> "$GITHUB_ENV"
- name: "Check for GAP manual"
shell: bash
run: |
Expand Down