-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(compose): Docker Compose plugin #4662
Conversation
This is now ready for review. From the guide: This plugin allows you to integrate Docker Compose projects into your Garden project. It works by parsing the Docker Compose projects, and creating Build and Deploy actions for each service in the project. You can then easily add Run and Test actions to complement your Compose project. This can be very useful e.g. for running tests against a Docker Compose stack in CI (and locally), and to wrap various scripts you use during development (e.g. a Run for seeding a database with test data, or a Run for generating a database migration inside a container that you're developing). The provided action types are (links point to the corresponding reference docs):
Here's a screenshot and a screencap of the plugin in action: ![]() docker-compose-readme-recording.mov |
2e41f45
to
59af236
Compare
How do we feel about this one, @edvald? I think it should be good for merging (would be good to get it on |
4ffe559
to
01a8265
Compare
Also wrote getStatus handler for Compose, and finished various other TODOs in the plugin code. Also added an async lock around network creation to avoid race conditions when deploying when one or more Docker networks don't exist yet.
This is a more general term and feels less jargony .)
Also: Prune unused Docker networks in the `cleanupEnvironment` handler.
The Docker Compose plugin is now ready for general use. We're still labelling it as experimental. Tests were added for the main action handlers and flows, and several things fixed and improved along the way. Also added an initial usage guide and improved the docstrings.
01a8265
to
75879f6
Compare
Still a bunch to be done, and currently branched off the
plugin-sdk-pt2
.Just putting here for safe keeping and early review if anyone is particularly interested .)