improvement(terraform): support dynamic backends #6828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eysi09
force-pushed
the
tf-backend-config
branch
3 times, most recently
from
c92162e to
35b5ceb
Compare
eysi09
changed the title
eysi09
force-pushed
the
tf-backend-config
branch
from
35b5ceb to
e87d8bf
Compare
eysi09
force-pushed
the
tf-backend-config
branch
3 times, most recently
from
386b489 to
c279759
Compare
thsig
previously approved these changes
Feb 10, 2025
| const hasChanged = | ||
| (currentBackendConfig && | ||
| isPlainObject(currentBackendConfig) && | ||
| !Object.entries(backendConfig).every(([key, value]) => { |
There was a problem hiding this comment.
Just out of curiosity, is there a reason you're not using something like isEqual from lodash-es for the object comparison here?
There was a problem hiding this comment.
No, just didn't think of it tbh
thsig
previously approved these changes
Feb 10, 2025
This change introduces a `backendConfig` field on the Terraform provider and action types. This field allows users to dynamically set the backend config for their Terraform stacks. Terraform itself doesn't allow variables in the backend config so this can be used instead to dynamically set the backend based on e.g. the environment.
eysi09
force-pushed
the
tf-backend-config
branch
from
c52fd43 to
ac65634
Compare
thsig
approved these changes
Feb 10, 2025
twelvemo
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This change introduces a
backendConfigfield on the Terraformprovider and action types.
This field allows users to dynamically set the backend config for
their Terraform stacks.
Terraform itself doesn't allow variables in the backend config
so this can be used instead to dynamically set the backend
based on e.g. the environment.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
I still need to update the docs on the Terraform provider and remove the "
sedhack". It's also an open question whether we mark this as experimental for now.But I can address both in a follow up PR.