Skip to content

Commit

Permalink
refactor: drop obsolete parameters
Browse files Browse the repository at this point in the history
Drop ocm-coordinates where no longer needed. This allows codepaths that
do not actually have a dependency towards OCM / an
OCM-Component-Descriptor to no longer require callers to provide those.
  • Loading branch information
ccwienk committed Jan 16, 2025
1 parent 4638947 commit 619405c
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 15 deletions.
2 changes: 0 additions & 2 deletions .github/actions/draft-release/update_draft_release.py
Original file line number Diff line number Diff line change
Expand Up @@ -152,8 +152,6 @@ def github_api_lookup(repo_url):
github_helper.create_draft_release(
name=draft_release_name,
body=release_notes_md,
component_version=component.version,
component_name=component.name,
)
else:
if not draft_release.body == release_notes_md:
Expand Down
2 changes: 0 additions & 2 deletions concourse/steps/draft_release.mako
Original file line number Diff line number Diff line change
Expand Up @@ -130,8 +130,6 @@ if not draft_release:
github_helper.create_draft_release(
name=draft_name,
body=release_notes_md,
component_version=processed_version,
component_name=component.name,
)
else:
if not draft_release.body == release_notes_md:
Expand Down
1 change: 0 additions & 1 deletion concourse/steps/release.mako
Original file line number Diff line number Diff line change
Expand Up @@ -541,7 +541,6 @@ try:
github_helper.update_release_notes(
tag_name=version_str,
body=release_notes_md,
component_name=component.name,
)
git_helper.push('refs/notes/commits', 'refs/notes/commits')
except:
Expand Down
2 changes: 0 additions & 2 deletions concourse/steps/release.py
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,6 @@ def github_release(
draft_release=release,
release_tag=release_tag,
release_version=release_version,
component_name=component_name,
)
else:
release = github_helper.create_release(
Expand All @@ -414,7 +413,6 @@ def github_release(
draft=False,
prerelease=False,
name=release_version,
component_name=component_name,
)


Expand Down
8 changes: 0 additions & 8 deletions github/util.py
Original file line number Diff line number Diff line change
Expand Up @@ -462,8 +462,6 @@ def create_release(
draft: bool=False,
prerelease: bool=False,
name: str=None,
component_name: str=None,
component_version: str=None,
):
if len(body) < MAXIMUM_GITHUB_RELEASE_BODY_LENGTH:
return self.repository.create_release(
Expand Down Expand Up @@ -511,24 +509,19 @@ def create_draft_release(
self,
name: str,
body: str,
component_name: str=None,
component_version: str=None,
):
return self.create_release(
tag_name='',
name=name,
body=body,
draft=True,
component_name=component_name,
component_version=component_version,
)

def promote_draft_release(
self,
draft_release,
release_tag,
release_version,
component_name: str=None,
):
draft_release.edit(
tag_name=release_tag,
Expand All @@ -554,7 +547,6 @@ def promote_draft_release(
def update_release_notes(
self,
tag_name: str,
component_name: str,
body: str,
) -> bool:
ci.util.not_empty(tag_name)
Expand Down

0 comments on commit 619405c

Please sign in to comment.