Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rm almost all remainders of ctx_repository #1077

Merged
merged 3 commits into from
Nov 13, 2024
Merged

rm almost all remainders of ctx_repository #1077

merged 3 commits into from
Nov 13, 2024

Conversation

ccwienk
Copy link
Member

@ccwienk ccwienk commented Nov 12, 2024

No description provided.

@gardener-robot gardener-robot added the needs/review Needs review label Nov 12, 2024
@gardener-robot gardener-robot added the size/s Size of pull request is small (see gardener-robot robot/bots/size.py) label Nov 12, 2024
ccwienk added a commit to gardener/landscaper that referenced this pull request Nov 13, 2024
@ccwienk
use ocm-repository-url rather than cfg-name
e63c0ec 
see: gardener/cc-utils#1077
@ccwienk ccwienk mentioned this pull request Nov 13, 2024
Merged
ccwienk added a commit to gardener/landscaper-service that referenced this pull request Nov 13, 2024
@ccwienk
explicitly configure ocm-repository-url
93acab7 
see gardener/cc-utils#1077
@ccwienk ccwienk mentioned this pull request Nov 13, 2024
Merged
@gardener-robot gardener-robot added size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) and removed size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Nov 13, 2024
@gardener-robot gardener-robot added size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else and removed size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Nov 13, 2024
8R0WNI3
8R0WNI3 approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@8R0WNI3 8R0WNI3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one remark, otherwise /lgtm

cnudie/retrieve.py Show resolved Hide resolved
@ccwienk ccwienk merged commit 870bc04 into master Nov 13, 2024
5 checks passed
@ccwienk ccwienk deleted the cleanup-ctx branch November 13, 2024 18:27
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Nov 13, 2024
guewa pushed a commit to gardener/landscaper-service that referenced this pull request Nov 15, 2024
@ccwienk
explicitly configure ocm-repository-url (#450)
37137ac 
see gardener/cc-utils#1077
guewa pushed a commit to gardener/landscaper that referenced this pull request Nov 15, 2024
@ccwienk
use ocm-repository-url rather than cfg-name (#1260)
dbb625a 
see: gardener/cc-utils#1077
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@8R0WNI3 8R0WNI3 8R0WNI3 approved these changes

@zkdev zkdev Awaiting requested review from zkdev zkdev is a code owner

Assignees
No one assigned
Labels
needs/review Needs review needs/second-opinion Needs second review by someone else size/l Size of pull request is large (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ccwienk @8R0WNI3 @gardener-robot