Skip to content

Enhance golangci-lint setup #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 2, 2025
Merged

Enhance golangci-lint setup #40

merged 5 commits into from
Apr 2, 2025

Conversation

nickytd
Copy link
Collaborator

@nickytd nickytd commented Apr 2, 2025

This PR adds linters and formatters to the projects

golangci-lint.run

Following linters are now part of the build:

  • errcheck
  • gocritic
  • govet
  • nlreturn
  • revive
  • staticcheck
  • unused
  • whitespace
  • wsl

Following formatters are now part of the build:

  • gci
  • gofmt
The project build now features an extended set of linters.

nickytd added 3 commits April 2, 2025 09:58
- switch goimports and goimports-reviser_tool to gci
- switch go fmt and go vet to golangci-lint v2 formatters and linters
- print running make target
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 2, 2025
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 2, 2025
@nickytd nickytd force-pushed the update-golangci-lint branch from b86b503 to f4fae4a Compare April 2, 2025 08:31
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 2, 2025
@nickytd nickytd merged commit 2ea0fa1 into main Apr 2, 2025
10 checks passed
@gardener-robot gardener-robot added needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged) labels Apr 2, 2025
@nickytd nickytd deleted the update-golangci-lint branch April 2, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants