Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Go, K8s and Gardener dependencies #73

Merged
merged 4 commits into from
Oct 10, 2024
Merged

Upgrade Go, K8s and Gardener dependencies #73

merged 4 commits into from
Oct 10, 2024

Conversation

ashwani2k
Copy link
Contributor

@ashwani2k ashwani2k commented Sep 20, 2024 •
edited
Loading

What this PR does / why we need it:
Update goLang version to v1.23 to make it more secure.
Also updates the k8s.io/apiMachinery to v0.24.3 from v0.23.4 to fix an issue with patching by Kupid where it was removing the minDomains from the spec.

For now we have not updated the g/g to the latest release as we would like to work on #33

Which issue(s) this PR fixes:
Fixes #72 #74

Special notes for your reviewer:

Release note:

Updated goLang version to v1.23.1 and k8s version to v0.24.3 along with g/g to v1.50

Kupid now supports using match expressions as part of podSelectors in defining scheduling policies

Fixed a bug where Kupid patches out minDomains from TopologySpreadConstraints

@ashwani2k ashwani2k requested a review from a team as a code owner September 20, 2024 08:49
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Sep 20, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 20, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 20, 2024
@ashwani2k ashwani2k force-pushed the upgrade-go-version-1.23.1 branch from f5a5a4f to 13f0344 Compare September 20, 2024 08:56
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 20, 2024
@ashwani2k ashwani2k force-pushed the upgrade-go-version-1.23.1 branch from 13f0344 to b9c339e Compare September 20, 2024 08:59
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 20, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 20, 2024
@ashwani2k ashwani2k force-pushed the upgrade-go-version-1.23.1 branch from b9c339e to 202ce95 Compare September 20, 2024 09:05
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 20, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 20, 2024
@ashwani2k ashwani2k force-pushed the upgrade-go-version-1.23.1 branch from 202ce95 to 3122f60 Compare September 24, 2024 08:15
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 24, 2024
@ashwani2k ashwani2k force-pushed the upgrade-go-version-1.23.1 branch from 3122f60 to 0918fdc Compare September 24, 2024 08:22
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 24, 2024
@ashwani2k ashwani2k force-pushed the upgrade-go-version-1.23.1 branch from 0918fdc to b44d771 Compare September 24, 2024 08:31
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 24, 2024
@ashwani2k ashwani2k force-pushed the upgrade-go-version-1.23.1 branch from b44d771 to 338c6a8 Compare September 24, 2024 08:39
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 24, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 24, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 26, 2024
@gardener-robot gardener-robot added size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Sep 26, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 27, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 27, 2024
@ashwani2k ashwani2k changed the title Update Go version to 1.23.1 Update Go K8s and Gardener dependencies Sep 28, 2024
@ashwani2k ashwani2k changed the title Update Go K8s and Gardener dependencies Update Go, K8s and Gardener dependencies Sep 28, 2024
@ashwani2k ashwani2k force-pushed the upgrade-go-version-1.23.1 branch from b1a0a14 to 56a82d2 Compare September 30, 2024 07:14
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 30, 2024
@ashwani2k ashwani2k changed the title Update Go, K8s and Gardener dependencies Upgrade Go, K8s and Gardener dependencies Sep 30, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 30, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 30, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 1, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 1, 2024
shreyas-s-rao
shreyas-s-rao requested changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@shreyas-s-rao shreyas-s-rao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashwani2k thanks for the PR! Please address the couple of nits I've pointed out. Other than that, lgtm.

main.go Outdated Show resolved Hide resolved
charts/gardener-extension-kupid/templates/clusterpodschedulingpolicy.yaml Show resolved Hide resolved
@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Oct 9, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 9, 2024
shreyas-s-rao
shreyas-s-rao approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@shreyas-s-rao shreyas-s-rao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes.
/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/changes Needs (more) changes needs/review Needs review needs/second-opinion Needs second review by someone else labels Oct 10, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 10, 2024
@ashwani2k ashwani2k merged commit eb0e559 into master Oct 10, 2024
7 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Oct 10, 2024
@shreyas-s-rao shreyas-s-rao mentioned this pull request Oct 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shreyas-s-rao shreyas-s-rao shreyas-s-rao approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/l Size of pull request is large (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kupid patches out minDomains from TopologySpreadConstraints
6 participants
@ashwani2k @shreyas-s-rao @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot