Skip to content

Update go to version 1.24.2 #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 9, 2025
Merged

Update go to version 1.24.2 #177

merged 3 commits into from
Apr 9, 2025

Conversation

dimityrmirchev
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

OWA is now built using go version 1.24.2.

@dimityrmirchev dimityrmirchev requested a review from a team as a code owner April 9, 2025 07:59
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Apr 9, 2025
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 9, 2025
@gardener-robot gardener-robot added size/s Size of pull request is small (see gardener-robot robot/bots/size.py) and removed size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Apr 9, 2025
@dimityrmirchev dimityrmirchev added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 9, 2025
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 9, 2025
nickytd
nickytd reviewed Apr 9, 2025
View reviewed changes
Copy link
Contributor

@nickytd nickytd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

.golangci.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text exclude patterns can be removed and the entire configuration simplified by explicit configuration to revive linter:

aka:

version: "2"
run:
  concurrency: 4
linters:
  enable:
    - gocritic
    - revive
  settings:
    revive:
      rules:
        - name: dot-imports
          disabled: true
        - name: indent-error-flow
          disabled: true
        - name: package-comments
          disabled: true

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Addressed with 9770e9a

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Apr 9, 2025
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 9, 2025
nickytd
nickytd previously approved these changes Apr 9, 2025
View reviewed changes
@gardener-robot gardener-robot added needs/review Needs review and removed needs/review Needs review labels Apr 9, 2025
@dimityrmirchev @nickytd
Address review feedback
9770e9a 
Co-authored-by: Niki Dokovski <nickytd@gmail.com>
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 9, 2025
nickytd
nickytd approved these changes Apr 9, 2025
View reviewed changes
Copy link
Contributor

@nickytd nickytd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@dimityrmirchev dimityrmirchev merged commit edf850c into gardener:master Apr 9, 2025
7 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Apr 9, 2025
@dimityrmirchev dimityrmirchev mentioned this pull request Apr 9, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickytd nickytd nickytd approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dimityrmirchev @nickytd @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot