Fixes sending messages from the Android app to the Garmin watches#3
Open
pdeubel wants to merge 1 commit intogarmin:mainfrom
Open
Fixes sending messages from the Android app to the Garmin watches#3pdeubel wants to merge 1 commit intogarmin:mainfrom
pdeubel wants to merge 1 commit intogarmin:mainfrom
Conversation
- Sending messages must be done outside of the UI thread -> use coroutines for this - Kotlin coroutines require a scope, therefore I included the androidx lifecycle dependency, and switched the DeviceActivity to be an AppCompatActivity (otherwise the lifecycle scope did not work) - This also required changing the themes to be AppCompat themes (the design should be equal to the previous themes), and bumping the SKD targets to 32
franciscobarrios
approved these changes
Oct 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described in #2, sending messages from the Android app to the Garmin watch (in my case the Connect IQ simulator) did not work and resulted in a
android.os.NetworkOnMainThreadException. This error is caused when sending messages in the main/UI thread. I fixed it by moving the message sending to a coroutine.Additional changes:
I tested it by setting the connection type to
ConnectIQ.IQConnectType.TETHEREDinMainActivity.kthere:connectiq-android-sdk/Comm Android/app/src/main/java/com/garmin/android/apps/connectiq/sample/comm/activities/MainActivity.kt
Line 95 in 9ea3c65