💚 Fix coverage in CI

garytyler · Aug 1, 2021 · bbe0396 · bbe0396
1 parent 53796de
commit bbe0396
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 16 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -83,14 +83,17 @@ jobs:
         uses: actions/setup-ruby@v1
         with:
           ruby-version: 2.6
+
       - name: Install fpm (for Linux)
         if: runner.os == 'Linux'
         run: |
           gem install --no-document fpm
+
       - name: Build (${{runner.os}})
         run: |
           poetry run python build.py freeze
           poetry run python build.py installer
+
       - name: Upload ${{runner.os}} installer
         uses: actions/upload-artifact@v2
         with:
@@ -100,18 +103,10 @@ jobs:
             dist/*.dmg
             dist/*.exe
 
-  upload-coverage-reports:
-    needs: build
-    runs-on: ubuntu-latest
-    steps:
-      - name: Download test coverage
-        uses: actions/download-artifact@v2
-        with:
-          name: coverage
-          path: ./coverage
       - name: Upload Test Coverage
-        uses: codecov/codecov-action@v1
+        uses: codecov/codecov-action@v2
         with:
           token: ${{secrets.CODECOV_TOKEN}}
-          directory: ./coverage
+          files: coverage-${{runner.os}}.xml
+          flags: ${{runner.os}}
           fail_ci_if_error: true
diff --git a/tests/test_main.py b/tests/test_main.py
@@ -8,8 +8,6 @@ def test_play_on_load(qtbot, main_win, media_dir):
     qtbot.waitUntil(lambda: playlist_view.model().rowCount() > 0)
     time_at_load = time_slider.value()
     qtbot.wait(500)
-    time_check_1 = time_slider.value()
-    qtbot.wait(500)
-    time_check_2 = time_slider.value()
-    assert time_check_1 and time_check_2
-    assert time_at_load != time_check_1 != time_check_2
+    time_check = time_slider.value()
+    assert time_check
+    assert time_at_load != time_check