Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GASP-1826] reverts swap trx fees #877

Merged
merged 5 commits into from
Jan 21, 2025
Merged

Conversation

vanderian
Copy link
Contributor

swaps always pays commission
min fee fix
fee goes to trsy, bnb, pool
fix valuation where it applies to the real, not predicted swap value

swaps always pays commission
min fee fix
fee goes to trsy, bnb, pool
fix valuation where it applies to the real, not predicted swap value
@vanderian vanderian requested review from goncer and iStrike7 January 13, 2025 22:02
@vanderian vanderian changed the title reverts swap trx fees [GASP-1826] reverts swap trx fees Jan 14, 2025
Copy link
Member

@mateuszaaa mateuszaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vanderian vanderian merged commit 40a2544 into eth-rollup-develop Jan 21, 2025
67 checks passed
@vanderian vanderian deleted the feature/revert-fees branch January 21, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants