Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to cancel actions #463

Closed
Tracked by #473
mostafa opened this issue Mar 1, 2024 · 2 comments · Fixed by #496
Closed
Tracked by #473

Add a way to cancel actions #463

mostafa opened this issue Mar 1, 2024 · 2 comments · Fixed by #496
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@mostafa
Copy link
Member

mostafa commented Mar 1, 2024

From act/registry.go:253:

// TODO: Add a way to cancel the action.

This can be achieved using context.WithTimeout or something similar, just like policy evaluation timeout.

@mostafa mostafa converted this from a draft issue Mar 1, 2024
@mostafa mostafa added the enhancement New feature or request label Mar 1, 2024
@Hamsajj
Copy link
Contributor

Hamsajj commented Mar 11, 2024

Hello, I'd like to work on this if no one else is.

Do you want to add a timeout option to async actions and their config? or create a way to signal them somehow to be canceled?

@mostafa mostafa moved this from ✨ New to 🚧 In progress in GatewayD Core Public Roadmap Mar 11, 2024
@mostafa mostafa added this to the v0.9.x milestone Mar 11, 2024
@mostafa
Copy link
Member Author

mostafa commented Mar 11, 2024

Hey @Hamsajj,

I want both sync and async functions to have a timeout, so that they can be cancelled either via a timeout or calling the cancel function. In the future, maybe we can have a list of running actions, especially long-running async ones, so we can cancel them via the API or the #472. The scope of this ticket is to only have the timeout cancellation.

@mostafa mostafa moved this from 🚧 In progress to 👀 In review in GatewayD Core Public Roadmap Mar 14, 2024
@mostafa mostafa moved this from 👀 In review to 🔀 Merged in GatewayD Core Public Roadmap Mar 14, 2024
@mostafa mostafa moved this from 🔀 Merged to 🎉 Done in GatewayD Core Public Roadmap Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

2 participants