-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add timeout for running actions #496
Conversation
@Hamsajj I merged the changes on the SDK and you can rebase from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Hamsajj,
Thanks for your awesome contribution! 🙏
Overall LGTM! I added a few comments. Note that I updated the SDK, so you can rebase from the main
branch and tidy the deps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Ticket(s)
Description
(This PR is in draft because it depends on gatewayd-io/gatewayd-plugin-sdk#26)
This PR will close #463 by adding timeout for running action.
Timeout will be defined by two different configs. One on the act system level, which will act as a default timeout and is added in this PR. the other config is on Action level, which allows each action to have a different timeout and will override the default one.
That config is added in gatewayd-io/gatewayd-plugin-sdk#26
If both of these values are zero, actions will run without any timeout.
Related PRs
gatewayd-io/gatewayd-plugin-sdk#26
Development Checklist
make gen-docs
command.Legal Checklist