Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout for running actions #496

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Conversation

Hamsajj
Copy link
Contributor

@Hamsajj Hamsajj commented Mar 14, 2024

Ticket(s)

Description

(This PR is in draft because it depends on gatewayd-io/gatewayd-plugin-sdk#26)
This PR will close #463 by adding timeout for running action.

Timeout will be defined by two different configs. One on the act system level, which will act as a default timeout and is added in this PR. the other config is on Action level, which allows each action to have a different timeout and will override the default one.
That config is added in gatewayd-io/gatewayd-plugin-sdk#26

If both of these values are zero, actions will run without any timeout.

Related PRs

gatewayd-io/gatewayd-plugin-sdk#26

Development Checklist

  • I have added a descriptive title to this PR.
  • I have squashed related commits together.
  • I have rebased my branch on top of the latest main branch.
  • I have performed a self-review of my own code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added docstring(s) to my code.
  • I have made corresponding changes to the documentation (docs).
  • I have updated docs using make gen-docs command.
  • I have added tests for my changes.
  • I have signed all the commits.

Legal Checklist

@mostafa
Copy link
Member

mostafa commented Mar 14, 2024

@Hamsajj I merged the changes on the SDK and you can rebase from main now. 🙏

@mostafa mostafa self-requested a review March 14, 2024 23:17
Copy link
Member

@mostafa mostafa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Hamsajj,

Thanks for your awesome contribution! 🙏

Overall LGTM! I added a few comments. Note that I updated the SDK, so you can rebase from the main branch and tidy the deps.

act/registry.go Outdated Show resolved Hide resolved
act/registry_test.go Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
Copy link
Member

@mostafa mostafa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Hamsajj Hamsajj marked this pull request as ready for review March 14, 2024 23:34
@mostafa mostafa changed the title wip: add timeout for running actions Add timeout for running actions Mar 14, 2024
@mostafa mostafa merged commit 2060af4 into gatewayd-io:main Mar 14, 2024
4 checks passed
smnmna99 pushed a commit that referenced this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a way to cancel actions
2 participants