Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s)
Description
The metrics server is multi-tenant (needs some integration work), yet the metrics merger feature seems to need more work to make it work as expected. Since a single instance of the plugin is always running in the entire lifecycle of a running GatewayD instance, it makes it hard to distinguish between metrics being emitted by the plugins. That is, a single (non-multi-tenant) metric is keeping track of the plugins' inner workings. This means that plugins should also support multi-tenancy.
Related PRs
N/A
Development Checklist
Legal Checklist