Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Multi-tenant metrics server #330

Closed
wants to merge 1 commit into from
Closed

Conversation

mostafa
Copy link
Member

@mostafa mostafa commented Sep 23, 2023

Ticket(s)

Description

The metrics server is multi-tenant (needs some integration work), yet the metrics merger feature seems to need more work to make it work as expected. Since a single instance of the plugin is always running in the entire lifecycle of a running GatewayD instance, it makes it hard to distinguish between metrics being emitted by the plugins. That is, a single (non-multi-tenant) metric is keeping track of the plugins' inner workings. This means that plugins should also support multi-tenancy.

Related PRs

N/A

Development Checklist

  • I have added a descriptive title to this PR.
  • I have squashed related commits together.
  • I have rebased my branch on top of the latest main branch.
  • I have performed a self-review of my own code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added docstring(s) and type annotations to my code.
  • I have made corresponding changes to the documentation (docs).
  • I have added tests for my changes.

Legal Checklist

yet the metrics merger feature seems to need more work to make it
work as expected. Since a single instance of the plugin is always
running in the entire lifecycle of a running GatewayD instance, it
makes it hard to distinguish between metrics being emitted by the
plugins. That is, a single (non-multi-tenant) metric is keeping
track of the plugins' inner workings. This means that plugins should
also support multi-tenancy.
@mostafa mostafa linked an issue Sep 23, 2023 that may be closed by this pull request
2 tasks
@mostafa
Copy link
Member Author

mostafa commented Nov 16, 2023

This will be picked up later.

@mostafa mostafa closed this Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor metrics server to be multi-tenant
1 participant