feat: get transitive dependencies by group id instead of limiting to artifact id #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slandelle
requested changes
Aug 11, 2023
…artifact id Motivation: Instead of having to remove transitive dependencies from new modules by (group id, artifact id) manually (e.g.: Gatling gRPC), it is simpler to get the dependencies of all the submodules of the known group ids instead.
notdryft
force-pushed
the
dependencies-by-group-id
branch
from
39e3479
to
b4ecaae
Compare
slandelle
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Instead of having to remove transitive dependencies from new modules by (group id, artifact id) manually (e.g.: Gatling gRPC), it is simpler to get the dependencies of all the submodules of the known group ids instead.