-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🏁 Citadel EOL #1228
🏁 Citadel EOL #1228
Conversation
Part of Citadel reaching EOL: #1223 Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this example line? https://github.com/gazebo-tooling/release-tools/blob/master/bloom/ros_gz/README.md?plain=1#L18
Add the Foxy - Citadel
combination to the List of EOL releases
section? https://github.com/gazebo-tooling/release-tools/blob/master/bloom/ros_gz/README.md?plain=1#L37
Remove the citadel
block from _dashboard_lib.sh
? https://github.com/gazebo-tooling/release-tools/blob/master/terminal-dashboard/_dashboard_lib.sh#L9-L26
Remove the citadel
block from table.bash
? https://github.com/gazebo-tooling/release-tools/blob/master/terminal-dashboard/table.bash
I think this can be left as is, since it's just an example of officially supported ROS/Gazebo pairings. Even though Citadel is EOL, the fact that it was paired with ROS 2 Foxy has not changed.
This list is for unofficial Gazebo/ROS pairings, e.g. Harmonic/Humble while the official one is Fortress/Humble. Since Citadel never had an unofficial pairing, I don't think there's anything to do here.
Is there a reason to do so? Even if it's EOL, I think it's nice to have the ability to generate the citadel dashboard. The |
Not having a strong position here but I usually clean up most references to EOL distributions just to reduce the noise for the people reading the options. I'm fine with it to stay.
👍
Same than in first point, not an strong argument but we probably remove previous versions from the table to reduce the number of lines of code that the dashboard is hosting. I'm also fine with it to stay for some months just in case someone needs it a some point. |
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Part of #1223
DO NOT MERGE UNTIL Jan 1, 2025