Skip to content

Commit

Permalink
Reviewer feedback
Browse files Browse the repository at this point in the history
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
  • Loading branch information
azeey committed Nov 7, 2023
1 parent 78e9455 commit 1d0f992
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 6 deletions.
5 changes: 3 additions & 2 deletions ionic/GUI_tutorial.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,10 @@ gz sim shapes.sdf

`gz sim` will run the latest version of Gazebo you have installed.
You can check if you have more than one version of Gazebo installed by running `gz sim --versions`.
For example, if you have Ionic (8.x.x), Garden (7.x.x), and Fortress (6.x.x) installed, `--versions` might return:
For example, if you have Ionic (9.x.x), Harmonic (8.x.x), Garden (7.x.x), and Fortress (6.x.x) installed, `--versions` might return:

```bash
9.0.0
8.0.0
7.0.0
6.0.0
Expand All @@ -28,7 +29,7 @@ For example, if you have Ionic (8.x.x), Garden (7.x.x), and Fortress (6.x.x) ins
To ensure you're working with Ionic, include the `--force-version` directive when starting up:

```bash
gz sim --force-version 8.0.0 shapes.sdf
gz sim --force-version 9.0.0 shapes.sdf
```

## GUI
Expand Down
2 changes: 1 addition & 1 deletion ionic/install.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ This list of library versions may change up to the release date.
| gz-plugin | 3.x |
| gz-rendering | 9.x |
| gz-sensors | 9.x |
| gz-tools | 3.x |
| gz-tools | 2.x |
| gz-transport | 14.x |
| gz-utils | 3.x |
| sdformat | 15.x |
Expand Down
2 changes: 1 addition & 1 deletion ionic/install_osx_src.md
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ brew install assimp boost bullet cmake cppzmq dartsim@6.10.0 doxygen eigen fcl f
```

`dartsim@6.10.0` and `qt@5` are not sym-linked. To use those dependencies when building
`gz-physics7` and `gz-gui8`, run the following after installation:
`gz-physics8` and `gz-gui9`, run the following after installation:

For Macs with Intel processors, add them to `/usr/local`:

Expand Down
4 changes: 2 additions & 2 deletions ionic/install_windows_src.md
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ colcon graph
If that is the case, then you are ready to build the whole set of libraries:

```bash
colcon build --cmake-args -DBUILD_TESTING=OFF --merge-install --packages-up-to gz-sim8 gz-tools2
colcon build --cmake-args -DBUILD_TESTING=OFF --merge-install --packages-up-to gz-sim9 gz-tools2
```
Tests are turned off as they are not currently supported on Windows.

Expand Down Expand Up @@ -163,7 +163,7 @@ Although running `gz sim` without arguments is not supported on Windows,
and `gz sim -g` is also not supported, there is a workaround you can apply
to be able to launch `gz sim -g` on Windows.
> Manually comment [these lines](https://github.com/gazebosim/gz-sim/blob/gz-sim7_7.5.0/src/cmd/cmdsim.rb.in#L497-L501) and [these lines](https://github.com/gazebosim/gz-sim/blob/gz-sim7_7.5.0/src/cmd/cmdsim.rb.in#L558-L562) in file `install\lib\ruby\gz\cmdsim8.rb`.
> Manually comment [these lines](https://github.com/gazebosim/gz-sim/blob/gz-sim7_7.5.0/src/cmd/cmdsim.rb.in#L497-L501) and [these lines](https://github.com/gazebosim/gz-sim/blob/gz-sim7_7.5.0/src/cmd/cmdsim.rb.in#L558-L562) in file `install\lib\ruby\gz\cmdsim9.rb`.
This should allow you to run the GUI in a separate console, connecting to the server running in another console.
Expand Down

0 comments on commit 1d0f992

Please sign in to comment.