Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload to ign-gazebo docs to both api/gazebo and api/sim #436

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Apr 25, 2024

🦟 Bug fix

Summary

The upload_doc.sh script uploads to s3://gazebosim.org/api/gazebo/ when building gz-sim versions lower than 6 (Fortress). However, our website has links to https://gazebosim.org/api/sim/6/, which are currently outdated (there must have been a manual upload at some point). This fixes the problem by syncing the api/gazebo/${majorVersion} files into the api/sim/${majorVersion} directory.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

The upload_doc.sh script uploads to s3://gazebosim.org/api/gazebo/ when
building gz-sim versions lower than 6 (Fortress). However, our website
has links to https://gazebosim.org/api/sim/6/, which are currently
outdated (there must have been a manual upload at some point). This
fixes the problem by syncing the api/gazebo/${majorVersion} files into the api/sim/${majorVersion}
directory.

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey requested a review from mabelzhang as a code owner April 25, 2024 17:11
@azeey azeey requested a review from caguero April 25, 2024 17:11
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey merged commit b13c551 into gazebosim:master Apr 25, 2024
1 check passed
@azeey azeey deleted the fix_ign-gazebo_api_upload branch April 25, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants