Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows instructions updated in harmonic branch #487

Merged
merged 4 commits into from
Aug 29, 2024
Merged

Windows instructions updated in harmonic branch #487

merged 4 commits into from
Aug 29, 2024

Conversation

akky20
Copy link
Contributor

@akky20 akky20 commented Aug 16, 2024

🦟 Bug fix

Fixes #483

Summary

Changes doc text according to the mentioned parts in issue

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@akky20
Windows instructions updated in harmonic branch
f3f3a29 
Signed-off-by: Abhiroop Bhavsar <b22me002@iitj.ac.in>
@akky20 akky20 requested a review from mabelzhang as a code owner August 16, 2024 22:17
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Aug 16, 2024
azeey
azeey reviewed Aug 16, 2024
View reviewed changes
Copy link
Contributor

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I left some small comments.
There's also a note on line 145 that says Gazebo GUI is not yet working which needs to be updated.

You can also remove the line that says "Manually comment these lines"

harmonic/install_windows_src.md Outdated Show resolved Hide resolved
harmonic/install_windows_src.md Show resolved Hide resolved
@akky20
Updated Windows instructions updated in harmonic branch
3a4d514 
Signed-off-by: Abhiroop Bhavsar <b22me002@iitj.ac.in>
@akky20
Copy link
Contributor Author

akky20 commented Aug 16, 2024

Thanks for the contribution! I left some small comments. There's also a note on line 145 that says Gazebo GUI is not yet working which needs to be updated.

You can also remove the line that says "Manually comment these lines"

Done with the changes

@akky20
Copy link
Contributor Author

akky20 commented Aug 18, 2024

@azeey Please look at the changes

@akky20
update windows source installation page
e36e82e 
Signed-off-by: Abhiroop Bhavsar <b22me002@iitj.ac.in>
@azeey azeey merged commit 6b0c03b into gazebosim:master Aug 29, 2024
5 checks passed
azeey added a commit to azeey/docs that referenced this pull request Jan 9, 2025
@akky20 @azeey
Windows instructions updated in harmonic branch (gazebosim#487)
8af71a7 
* Windows instructions updated in harmonic branch

Signed-off-by: Abhiroop Bhavsar <b22me002@iitj.ac.in>

* Updated Windows instructions updated in harmonic branch

Signed-off-by: Abhiroop Bhavsar <b22me002@iitj.ac.in>

* update windows source installation page

Signed-off-by: Abhiroop Bhavsar <b22me002@iitj.ac.in>

---------

Signed-off-by: Abhiroop Bhavsar <b22me002@iitj.ac.in>
Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@traversaro traversaro traversaro left review comments

@azeey azeey azeey approved these changes

@mabelzhang mabelzhang Awaiting requested review from mabelzhang

Assignees
No one assigned
Labels
🎵 harmonic Gazebo Harmonic
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows instructions should be updated
3 participants
@akky20 @azeey @traversaro